infra: extend Quality Baseline with CSS variable, divider, and FOUC rules#67
Merged
Merged
Conversation
…ules Add three rules to AGENTS.md Quality Baseline that encode the content-page UX lessons captured in session memory: - Spacing / border-width / color must reference CSS variables; bare rem/px literals for margin, padding, gap, or border-width are a review finding. Pointer to the new css-variable-consistency guide for rationale. - Adding or changing a divider-style border requires auditing all dividers in the file as a set; mixed widths or mixed color tokens count as inconsistency. - Dark-theme pages must inline critical background/color CSS in <head> with a light-mode media-query fallback to prevent FOUC on first paint. These rules are already enforced in the frontend-interaction-review skill's new Visual consistency group; mirroring them here makes them discoverable during pre-work without requiring the agent to open the skill file first. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
wilsonwangdev
added a commit
that referenced
this pull request
May 8, 2026
## Summary Closeout for the AEO baseline workstream (#69, #70). Captures the process failure that surfaced mid-session and updates the pre-work checklist to prevent recurrence. ## Why this exists While shipping #69 and #70, both PRs initially carried two orphan commits from a stale local branch whose contents had already squash-merged to `main` as #68. Different SHAs hid the equivalence from `git fetch -p`. The reviewer caught it; both PRs were rebased onto `origin/main` and force-pushed. The journal entry is the third PR-hygiene failure recorded. The pattern across all three: rules exist, but the procedural trigger points where rules must fire are under-specified. ## Changes - `journal/2026-05-08-stale-branch-base-pollution.md` — what happened, root cause, fix, evolution notes (EN+ZH). - `AGENTS.md` Git Workflow — new pre-work step 9: explicitly verify `git branch --show-current` returns `main` right before `git checkout -b`. Squash-merge makes stale-branch detection unreliable via SHA; this is a terminal-state assertion rather than a sequence of actions. - `ROADMAP.md` — check off #67, #69, #70; add "AI visibility / AEO content guide" as the next content item (the planned Layer 1 guide that closes this workstream). ## Manual follow-ups (tracked separately, not in this PR) External submissions that require login and cannot be automated from the repo: - [directory.llmstxt.cloud](https://directory.llmstxt.cloud) / [llmstxt.site](https://llmstxt.site) / [llms-txt-hub](https://github.com/thedaviddias/llms-txt-hub) — submit llms.txt URL - Bing Webmaster Tools — register + submit sitemap (unlocks AI Performance panel with citation counts) - Google Search Console — verify AI Overview citation visibility - [Perplexity Publisher Program](https://pplx.ai/publisher-program) — submit site for source consideration These will be handled out-of-band. The handbook's technical readiness for them shipped in #69 and #70.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add three rules to AGENTS.md Quality Baseline that encode the content-page UX lessons captured in session memory (
feedback_content_page_ux.md).Changes
Three new bullets in the Quality Baseline section:
--space-*,--border-*, and color tokens. Barerem/pxliterals for margin, padding, gap, or border-width are a review finding. Points at the newcontent/guides/css-variable-consistency/guide for rationale.--bordervs--border-bright) count as inconsistency.background/colorCSS in<head>with a light-mode media-query fallback to prevent FOUC.Why
The frontend-interaction-review skill's new Visual consistency group (PR #65) already encodes these rules. Mirroring them in the Quality Baseline makes them discoverable during pre-work without requiring the agent to open the skill file first — most pre-work checks live in AGENTS.md today.
Relation to other open PRs
Tested
npm run buildsucceeds — 26 pages generated. The added guide reference (content/guides/css-variable-consistency/en.md) is correct relative to merged state once PR #66 lands.