Sourcery Starbot ⭐ refactored wilsonusman/rockauto_api#1
Open
SourceryAI wants to merge 1 commit intowilsonusman:mainfrom
Open
Sourcery Starbot ⭐ refactored wilsonusman/rockauto_api#1SourceryAI wants to merge 1 commit intowilsonusman:mainfrom
SourceryAI wants to merge 1 commit intowilsonusman:mainfrom
Conversation
SourceryAI
commented
Apr 2, 2021
Comment on lines
-112
to
+128
| categories_list = [] | ||
|
|
||
| browser = mechanize.Browser() | ||
| page_content = browser.open( search_link ).read() | ||
| browser.close() | ||
|
|
||
| soup = BeautifulSoup(page_content, features='html5lib').find_all('a', attrs={'class', 'navlabellink'})[4:] | ||
|
|
||
| for x in soup: | ||
| categories_list.append( {'make': search_make, 'year': search_year, 'model': search_model, 'engine': search_engine, 'category': x.get_text(), 'link': 'https://www.rockauto.com' + str( x.get('href') ) }) | ||
|
|
||
| return categories_list | ||
| return [ | ||
| { | ||
| 'make': search_make, | ||
| 'year': search_year, | ||
| 'model': search_model, | ||
| 'engine': search_engine, | ||
| 'category': x.get_text(), | ||
| 'link': 'https://www.rockauto.com' + str(x.get('href')), | ||
| } | ||
| for x in soup | ||
| ] |
Author
There was a problem hiding this comment.
Function get_categories refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
Comment on lines
-131
to
+149
| sub_categories_list = [] | ||
|
|
||
| browser = mechanize.Browser() | ||
| page_content = browser.open( search_link ).read() | ||
| browser.close() | ||
|
|
||
| soup = BeautifulSoup(page_content, features='html5lib').find_all('a', attrs={'class', 'navlabellink'})[5:] | ||
|
|
||
| for x in soup: | ||
| sub_categories_list.append( {'make': search_make, 'year': search_year, 'model': search_model, 'engine': search_engine, 'category': search_category, 'sub_category': x.get_text(), 'link': 'https://www.rockauto.com' + str( x.get('href') ) }) | ||
|
|
||
| return sub_categories_list No newline at end of file | ||
| return [ | ||
| { | ||
| 'make': search_make, | ||
| 'year': search_year, | ||
| 'model': search_model, | ||
| 'engine': search_engine, | ||
| 'category': search_category, | ||
| 'sub_category': x.get_text(), | ||
| 'link': 'https://www.rockauto.com' + str(x.get('href')), | ||
| } | ||
| for x in soup | ||
| ] No newline at end of file |
Author
There was a problem hiding this comment.
Function get_sub_categories refactored with the following changes:
- Convert for loop into list comprehension (
list-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for starring sourcery-ai/sourcery ✨ 🌟 ✨
Here's your pull request refactoring your most popular Python repo.
If you want Sourcery to refactor all your Python repos and incoming pull requests install our bot.
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run: