Skip to content

media: fix wrong type of old stats report#997

Merged
pnts-se-whereby merged 3 commits into
mainfrom
pontus/cob-1348-handle-no-old-report-in-collectstats
May 12, 2026
Merged

media: fix wrong type of old stats report#997
pnts-se-whereby merged 3 commits into
mainfrom
pontus/cob-1348-handle-no-old-report-in-collectstats

Conversation

@pnts-se-whereby
Copy link
Copy Markdown
Contributor

@pnts-se-whereby pnts-se-whereby commented May 11, 2026

Description

Summary:

  • return Map instead of Array when getStats fails
  • add typing
  • return an object instead of array from getPeerConnectionsWithStatsReports

Related Issue:

Testing

Screenshots/GIFs (if applicable)

Checklist

  • My code follows the project's coding standards.
  • Prefixed the PR title and commit messages with the service or package name
  • I have written unit tests (if applicable).
  • I have updated the documentation (if applicable).
  • By submitting this pull request, I confirm that my contribution is made
    under the terms of the MIT license.

Additional Information

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 11, 2026

🦋 Changeset detected

Latest commit: 685cccc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@whereby.com/media Patch
@whereby.com/browser-sdk Patch
@whereby.com/core Patch
@whereby.com/assistant-sdk Patch
@whereby.com/react-native-sdk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pnts-se-whereby pnts-se-whereby force-pushed the pontus/cob-1348-handle-no-old-report-in-collectstats branch from ed50c53 to aee2bf4 Compare May 11, 2026 12:59
@pnts-se-whereby
Copy link
Copy Markdown
Contributor Author

/canary

@github-actions
Copy link
Copy Markdown
Contributor

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260511131024
pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260511131024
pnpm add @whereby.com/core@0.0.0-canary-20260511131024
pnpm add @whereby.com/media@0.0.0-canary-20260511131024
pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260511131024

@pnts-se-whereby pnts-se-whereby requested a review from geirbakke May 11, 2026 13:24
@pnts-se-whereby pnts-se-whereby changed the title media: return map-like object when getStats fails during stats collec… media: fix wrong type of old stats report May 11, 2026
@pnts-se-whereby
Copy link
Copy Markdown
Contributor Author

/canary

@github-actions
Copy link
Copy Markdown
Contributor

🚀 The canary releases have been published to npm.

You can test the releases by installing the newly published versions:

pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260512065405
pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260512065405
pnpm add @whereby.com/core@0.0.0-canary-20260512065405
pnpm add @whereby.com/media@0.0.0-canary-20260512065405
pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260512065405

@pnts-se-whereby pnts-se-whereby merged commit a1dc8b5 into main May 12, 2026
3 checks passed
@pnts-se-whereby pnts-se-whereby deleted the pontus/cob-1348-handle-no-old-report-in-collectstats branch May 12, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants