media: Fixes stats collection on firefox#995
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 3e44f19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260508070945pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260508070945pnpm add @whereby.com/core@0.0.0-canary-20260508070945pnpm add @whereby.com/media@0.0.0-canary-20260508070945pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260508070945 |
Contributor
|
/canary |
Contributor
|
🚀 The canary releases have been published to npm. You can test the releases by installing the newly published versions: pnpm add @whereby.com/assistant-sdk@0.0.0-canary-20260508111051pnpm add @whereby.com/browser-sdk@0.0.0-canary-20260508111051pnpm add @whereby.com/core@0.0.0-canary-20260508111051pnpm add @whereby.com/media@0.0.0-canary-20260508111051pnpm add @whereby.com/react-native-sdk@0.0.0-canary-20260508111051 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Firefox seems to be returning senders and receivers without tracks, probably for unidirection media sections, and inactive sections. This made parts of the stats collection (issues/posthog/insights but not rest of rtcstats) stop because of exception accessing track property, and wasting cycles trying again and again. Easily reproducible by starting/stopping a screenshare.
So now we just ignore senders/receivers without a track.