Override $identitySelect for CockroachDB adapter#1989
Closed
Override $identitySelect for CockroachDB adapter#1989
Conversation
CockroachDB doesn't support pg_get_serial_sequence() or currval() which the inherited PostgreSQL adapter uses. Override with a MAX-based query since CockroachDB's unique_rowid() generates monotonically increasing values (same approach as the Oracle adapter). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Wheels Test Matrix
Results for commit 2828efa. |
Contributor
Collaborator
Author
|
Closing in favor of #1896's RETURNING-based approach, which avoids the race condition inherent in SELECT MAX(pk). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$identitySelect()which usespg_get_serial_sequence()andcurrval()— neither of which CockroachDB supportsCockroachDBModel.cfcwith a MAX-based query, since CockroachDB'sunique_rowid()generates monotonically increasing valuesCloses #1971
Test plan
model("Foo").create(...)returns the correct primary key on CockroachDB🤖 Generated with Claude Code