Add "hide all popovers" algorithm#8886
Conversation
This was requested for cross referencing instead of "hide all popovers until" here: whatwg/fullscreen#204 (comment) This patch also fixes a bug where a null endpoint is passed to hide all popovers until, but hide all popovers until assumes endpoint is not null by looking for endpoint's node document. The bug is fixed by adding a required document parameter to hide all popovers until.
|
I wish I had seen this before creating #8889. Oh well. |
|
As part of this PR, please also double check that all the relevant terms and algorithms have been exported so whatwg/fullscreen#204 can reference them. There are some CI errors that indicate this hasn't happened yet. |
I made the new algorithm have |
These dfns need to be exported in order to be used in the fullscreen spec: whatwg/fullscreen#204
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
If endpoint is document, do we need to set endpoint to null?
annevk
left a comment
annevk
left a comment
There was a problem hiding this comment.
Thanks for the clarification, one nit left.
In whatwg#8886 I made the endpoint parameter in hide all popovers until never null by making it either a document or an element, but I forgot to change this null check to a document check. Fixes whatwg#8963
2 participants
This was requested for cross referencing instead of "hide all popovers until" here:
whatwg/fullscreen#204 (comment)
This patch also fixes a bug where a null endpoint is passed to hide all popovers until, but hide all popovers until assumes endpoint is not null by looking for endpoint's node document. The bug is fixed by adding a required document parameter to hide all popovers until.
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )
/popover.html ( diff )