Skip to content

Explicitly pass around the "perform the fetch" hook#8328

Merged
domenic merged 7 commits intowhatwg:mainfrom
nicolo-ribaudo:explicit-perform-the-fetch-hook
Oct 4, 2022
Merged

Explicitly pass around the "perform the fetch" hook#8328
domenic merged 7 commits intowhatwg:mainfrom
nicolo-ribaudo:explicit-perform-the-fetch-hook

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Collaborator

@nicolo-ribaudo nicolo-ribaudo commented Sep 28, 2022

This is part of the second bullet point of #7996, and its first nested point.

  • I deleted support for the hook from fetch a classic script, fetch an external module script graph, and fetch an import() module script graph, since they were never called with custom steps.

cc @domenic


/webappapis.html ( diff )
/workers.html ( diff )

Copy link
Copy Markdown
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work as always?!

Would you be up for working on a PR to https://w3c.github.io/ServiceWorker/ that we could merge around the same time?

Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
Comment thread source Outdated
@nicolo-ribaudo
Copy link
Copy Markdown
Collaborator Author

Done! SW pr: w3c/ServiceWorker#1658

@domenic domenic merged commit f3550cd into whatwg:main Oct 4, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the explicit-perform-the-fetch-hook branch October 4, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clarification Standard could be clearer topic: script

Development

Successfully merging this pull request may close these issues.

2 participants