Set requests' user activation flag during navigation.#5203
Merged
Conversation
In order to support Fetch Metadata's `Sec-Fetch-User` header, this patch sets navigation requests' user activation flag if the navigation is triggered while the source browsing context has transient activation.
Member
Author
|
(Note that this patch depends on whatwg/fetch#993 landing first.) |
annevk
approved these changes
Jan 10, 2020
Member
annevk
left a comment
There was a problem hiding this comment.
This looks accurate. @mustaqahmed want to double check?
Contributor
|
This looks good from user activation perspective. Two questions/nits:
|
Member
Member
Author
|
Thanks, @mustaqahmed (and @domenic for the ping)! I've added the hyphen to WDYT, @annevk? |
3 tasks
annevk
approved these changes
Feb 11, 2020
Member
Author
|
Today's commits merge in the last few months of changes, and adjusts the patch to talk about a request's "user activation" boolean, per the rename in whatwg/fetch#993. |
annevk
approved these changes
Mar 4, 2021
mikewest
added a commit
to w3c/webappsec-fetch-metadata
that referenced
this pull request
Jul 13, 2021
After whatwg/fetch#948, whatwg/fetch#993, and whatwg/html#5203, the integration with Fetch and HTML is complete. This patch points to those integration points rather than claiming that there's still work to be done. Closes #73.
mikewest
added a commit
to w3c/webappsec-fetch-metadata
that referenced
this pull request
Jul 20, 2021
After whatwg/fetch#948, whatwg/fetch#993, and whatwg/html#5203, the integration with Fetch and HTML is complete. This patch points to those integration points rather than claiming that there's still work to be done. Closes #73.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to support Fetch Metadata's
Sec-Fetch-Userheader, this patchsets navigation requests' user activation flag if the navigation is
triggered while the source browsing context has transient activation.
/browsing-the-web.html ( diff )
/infrastructure.html ( diff )