Rename selectedcontent "disabled" to "in valid tree position", inverting the value

[keithamus]

This fixes #12367 by renaming selectedcontent's disabled boolean to is in valid tree position. The value now becomes true when selectedcontent is in a valid tree position, otherwise false. This is flipped from the disabled boolean earlier, so all callsites have been flipped.

This also renames the select's enabled selectedcontent to select's selectedcontent in valid tree position, to better align that naming also.

---

/form-elements.html ( diff )

[jnjaeschke]

LGTM

[annevk]

But also, it's maybe better if @josepharhar makes this change as part of his PR so he doesn't have to deal with a conflict?

[josepharhar]

But also, it's maybe better if @josepharhar makes this change as part of his PR so he doesn't have to deal with a conflict?

I'm happy to deal with the merge conflict, I'd like to get this done now so it doesn't look like we have as many open select issues. I don't know when that PR will actually get merged.

[annevk]

This is still changing an ID. I'm also not entirely sure about defaulting to true. I guess it's only an anti-pattern for arguments, but it feels kinda wrong here too.

[keithamus]

I've added a <span id=selectedcontent-disabled></span> here, which should work as an effective alias and no longer break links. Looks like this has been done in other places e.g. <h5 id="rel-alternate"><span id="link-type-alternate"></span> or <p id="structuredclone"><span id="structured-clone"></span>.

[annevk]

I'd prefer not adding more markup.

I guess having read this diff a few times now I'm also kinda neutral on this change, towards the negative side. I find it more verbose and less clear.