Set dialog is modal to false when removed from the document.#10459
Merged
Conversation
Member
Author
|
It seems this was actually already done in 9fcb6c3 so please forgive me if I've missed something glaringly obvious. I think this has regressed at some point though and it no longer is specced to happen? |
Member
|
Looks like #9093 (specifically 8430871#diff-41cf6794ba4200b839c53531555f0f3998df4cbb01a4d5cb0b94e3ca5e23947dL60407) may have accidentally refactored out this logic. |
domenic
approved these changes
Jul 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10452
This is just updating the spec to match reality.
(See WHATWG Working Mode: Changes for more details.)
/interactive-elements.html ( diff )