Skip to content

Set dialog is modal to false when removed from the document.#10459

Merged
domenic merged 1 commit into
whatwg:mainfrom
lukewarlow:dialog-remove-modality
Jul 8, 2024
Merged

Set dialog is modal to false when removed from the document.#10459
domenic merged 1 commit into
whatwg:mainfrom
lukewarlow:dialog-remove-modality

Conversation

@lukewarlow
Copy link
Copy Markdown
Member

@lukewarlow lukewarlow commented Jul 3, 2024

Fixes #10452

This is just updating the spec to match reality.

  • At least two implementers are interested (and none opposed):
  • Tests are written and can be reviewed and commented upon at:
  • Implementation bugs are filed:
    • Chromium: …
    • Gecko: …
    • WebKit: …
    • Deno (only for timers, structured clone, base64 utils, channel messaging, module resolution, web workers, and web storage): …
    • Node.js (only for timers, structured clone, base64 utils, channel messaging, and module resolution): …
  • MDN issue is filed: …
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/interactive-elements.html ( diff )

@lukewarlow
Copy link
Copy Markdown
Member Author

It seems this was actually already done in 9fcb6c3 so please forgive me if I've missed something glaringly obvious. I think this has regressed at some point though and it no longer is specced to happen?

@keithamus
Copy link
Copy Markdown
Member

keithamus commented Jul 4, 2024

Looks like #9093 (specifically 8430871#diff-41cf6794ba4200b839c53531555f0f3998df4cbb01a4d5cb0b94e3ca5e23947dL60407) may have accidentally refactored out this logic.

@domenic domenic added the topic: dialog The <dialog> element label Jul 8, 2024
@domenic domenic merged commit baeea82 into whatwg:main Jul 8, 2024
@lukewarlow lukewarlow deleted the dialog-remove-modality branch July 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic: dialog The <dialog> element

Development

Successfully merging this pull request may close these issues.

Should dialog removal steps unset is modal flag?

3 participants