Fix for PHP 5.6#3
Open
white-gecko wants to merge 4 commits intowez:masterfrom
Open
Conversation
- fixed a bug in yy_buffer_read update for large files - extended the createToken method to allow setting of custom token value
white-gecko
added a commit
to white-gecko/PHP-SparqlParser
that referenced
this pull request
Nov 25, 2016
This workaround is necessary due to a PHP bug: https://bugs.php.net/bug.php?id=68057. This lexer was built based on JLexPHP as proposed in wez/JLexPHP#3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a bug in PHP 5.6 regarding arrays in classes with more then 65538 elements and thus the since the key is limited to 64bit. This PHP bug is discussed in https://bugs.php.net/bug.php?id=68057. and marked as wont-fix.
This bug effects JLexPHP with the array for
$yy_cmap.With these commits, there is a workaround for this bug in PHP 5.6.