Handle hyperlinks better#476
Open
joshuapinter wants to merge 2 commits intoweshatheleopard:masterfrom
Open
Conversation
…n Excel of 65,530. Exceeding this limit will result in an error when opening up the file, similar to this: > We found a problem with some content in ‘.xlsx'. Do you want us to try to recover as much as we can? If you trust the source of this workbook, click Yes. With this change we now prevent the creation of hyperlinks if the limit of 65,530 has been reached. We will also output a warning to the Rails log but only once. It will show the worksheet name as well as the row and column where it was exceeded. Fixes weshatheleopard#475
…e the `HYPERLINK` formula to make it clickable. This also gets around the 65,530 hyperlinks per Worksheet limit in Excel as these `HYPERLINK` formulas do not contribute to that count. Related to weshatheleopard#475.
Author
|
We're going to use our fork in Production but I would much prefer to get these merged in upstream so we can use your A few things I can think of are:
Thanks! Joshua |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent adding more hyperlinks than the allowed limit per worksheet in Excel of 65,530.
Exceeding this limit will result in an error when opening up the file, similar to this:
With this change we now prevent the creation of hyperlinks if the limit of 65,530 has been reached.
We will also output a warning to the Rails log but only once. It will show the worksheet name as well as the row and column where it was exceeded.
Fixes #475
If the contents of a cell is a URL and does not include a formula, use the
HYPERLINKformula to make it clickable.This also gets around the 65,530 hyperlinks per Worksheet limit in Excel as these
HYPERLINKformulas do not contribute to that count.Related to #475.