Skip to content

fix mdtc#130

Merged
mlxu995 merged 2 commits into
wenet-e2e:mainfrom
William1617:main
May 18, 2026
Merged

fix mdtc#130
mlxu995 merged 2 commits into
wenet-e2e:mainfrom
William1617:main

Conversation

@William1617
Copy link
Copy Markdown
Contributor

No description provided.

@mlxu995
Copy link
Copy Markdown
Collaborator

mlxu995 commented Apr 10, 2023

Is your intention to remove redundant code?
but the value of "stack_num" not always bet set to 1, so we need to keep this variable to cover all the possibilities.

@William1617
Copy link
Copy Markdown
Contributor Author

Ok.But the stack_num and stack_size in TCNStack are reversed

@mlxu995
Copy link
Copy Markdown
Collaborator

mlxu995 commented May 26, 2023

Thank you for your careful check. We'd really appreciate it if you help to fix this error.

- 调整 build_dilations 方法中循环顺序,先遍历stack_num再遍历stack_size
- 修改 stack_tcn_blocks 函数中 TCNStack 参数顺序,保持代码逻辑一致性的同时,提升代码可读性和维护性
@mlxu995 mlxu995 merged commit 6b1426d into wenet-e2e:main May 18, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants