fix: use lastAppliedSpec for rolling update#2413
Closed
rugggger wants to merge 1 commit into03-30-fix_implement_spec_propagation_as_rolling_upgradefrom
Closed
fix: use lastAppliedSpec for rolling update#2413rugggger wants to merge 1 commit into03-30-fix_implement_spec_propagation_as_rolling_upgradefrom
rugggger wants to merge 1 commit into03-30-fix_implement_spec_propagation_as_rolling_upgradefrom
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Snapshot WarningsEnsure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice. Scanned FilesNone |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label main-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 31, 2026
graphite-app
Bot
requested review from
assafgi,
kristina-solovyova and
tigrawap
and removed request for
tigrawap
Graphite Automations"Add anton/matt/sergey/kristina as reviwers on operator PRs" took an action on this PR • (03/31/26)3 reviewers were added to this PR based on Anton Bykov's automation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Simplified spec version tracking by consolidating status fields and removing unnecessary hash-based change detection.
What changed?
LastAppliedSpecVersiontoLastAppliedSpecacross all container status trackingHandleSpecUpdates()- now propagates cluster spec fields to all containers using per-field diffs to avoid unnecessary patchesallowRotateNonAnnotated=falseWhy make this change?
We want to use
LastAppliedSpecfor the rolling updates flow