Remove outdated evaluate code and just use trainer.validate.#1327
Merged
jveitchmichaelis merged 1 commit intomainfrom Mar 3, 2026
Merged
Remove outdated evaluate code and just use trainer.validate.#1327jveitchmichaelis merged 1 commit intomainfrom
jveitchmichaelis merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
Okay, @jveitchmichaelis I think this ready to review. I removed predictions arg from the evaluate CLI, it was a weird edge pattern that didn't match the rest of the workflow. |
Collaborator
Author
|
I reverted the .toml, it was specific to my laptop, let's make that a separate PR. |
jveitchmichaelis
requested changes
Mar 3, 2026
sure the trainer stashes the entire results dictionary, not just logs the individual pieces to keep user behavior the same
0fd3808 to
69a71b8
Compare
Collaborator
Author
|
rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
__evaluate__and calculate_empty_frame accuracycloses #1316
and simplifies the code.
Thanks to @jveitchmichaelis for his idea here.