Open
Conversation
samuelmaddock
approved these changes
Feb 1, 2018
samuelmaddock
left a comment
samuelmaddock
left a comment
There was a problem hiding this comment.
Looking forward to this getting merged 👍
| this.used-- | ||
| swap(peers.values, peers.values.length - 1, removed.index) | ||
| peers.values.pop() | ||
| if (!peers.values.length) this.peers.remove(key) |
There was a problem hiding this comment.
Code looks similar to _evict below it, is there a chance for reuse?
Contributor
Author
There was a problem hiding this comment.
I ended up writing a new simple module that encapsulates this instead. https://github.com/mafintosh/record-cache. Wanna use this here and get rid of peer store in general
| if (!this._validateToken(host, token)) { | ||
| return this._rpc.error(peer, query, [203, 'cannot `announce_peer` with bad token']) | ||
| } | ||
| if (!this._validateToken(host, token)) return null |
Contributor
Author
There was a problem hiding this comment.
It still does the same. Kinda hard to see from the diff. Returning null in here triggers the .error handler in the caller
|
when will this be added? i can really use this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimental support for a BEP I'm writing to support
dht.unannounce(infoHash, [port], [cb]).Makes the client tell other peers that you wish to unannounce a previous announce. Has the same security semantics internally as announce, so should be good there.