Skip to content

fix: Workflow user guide improvements #3295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SuaYoo merged 2 commits into from
May 6, 2026
+1 −14
Merged

fix: Workflow user guide improvements #3295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c05c1c4
fix clicking link twice
SuaYoo May 5, 2026
8b34ec5
close user guide when navigating away from workflow
SuaYoo May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions frontend/src/features/crawl-workflows/workflow-editor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ export class WorkflowEditor extends BtrixElement {

disconnectedCallback(): void {
this.onPanelIntersect.cancel();
AppStateService.updateUserGuideOpen(false);
super.disconnectedCallback();
}

Expand Down
14 changes: 0 additions & 14 deletions frontend/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,20 +375,6 @@ export class App extends BtrixElement {
?open=${this.appState.userGuideOpen}
contained
@sl-hide=${() => AppStateService.updateUserGuideOpen(false)}
@sl-after-hide=${() => {
// FIXME There might be a way to handle this in Mkdocs, but updating
// only the hash doesn't seem to update the docs view
const iframe = this.userGuideDrawer.querySelector("iframe");

if (!iframe) return;

const src = iframe.src;
const hashIdx = src.indexOf("#");

if (hashIdx > -1) {
iframe.src = src.slice(0, src.indexOf("#"));
}
}}
>
<span slot="label" class="flex items-center gap-3">
<sl-icon name="book"></sl-icon>
Expand Down
Loading