fix list methods so psalm doesn't see it as list<never>#351
Merged
shadowhand merged 1 commit intowebmozarts:masterfrom Feb 27, 2026
Merged
fix list methods so psalm doesn't see it as list<never>#351shadowhand merged 1 commit intowebmozarts:masterfrom
shadowhand merged 1 commit intowebmozarts:masterfrom
Conversation
shadowhand
requested changes
Feb 26, 2026
alleknalle
force-pushed
the
list-never
branch
from
5f005af to
0e725d8
Compare
shadowhand
approved these changes
Feb 27, 2026
Collaborator
|
Released in version 2.1.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In version 2.1.3 annotations for all
listmethods have been changed to use@template T,@psalm-return list<T>and@psalm-assert list<T> $array(or something similar). This causes Psalm to sometimes think that an array islist<never>, see example https://psalm.dev/r/a999572021 and the test that I added.