Reorder operations to create service contact before setting email facet#4
Open
webit-kluever wants to merge 2 commits intowebit-de:masterfrom
Open
Reorder operations to create service contact before setting email facet#4webit-kluever wants to merge 2 commits intowebit-de:masterfrom
webit-kluever wants to merge 2 commits intowebit-de:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
THIS PR IS INCOMPLETE! The steps for SCWPD Creation from
RELEASE.mdare missing in this PR, as I currently do not have support for dacpac installed. Please create the scwdp files and add them to this PR before merging.Changes the order of operations in
XDbContactRepository.UpdateOrCreateXDbServiceContactWithEmailso that the contact is created before attempting to set the email facet. Additionally also updates the Docker files so that they are compatible with Sitecore 10.3.