Test that element.requestFullscreen() consumes user activation#36969
Merged
marcoscaceres merged 2 commits intoDec 8, 2022
Conversation
This makes a bunch of other tests redundant, as they're also calling requestFullscreen() twice, and should all fail in exactly the same way. element-request-fullscreen-same-manual.html is also converted to ensure that a second call in a new click does work, to ensure the failure isn't because the element is the same as the fullscreen element. Follows whatwg/fullscreen#153.
foolip
force-pushed
the
consume-user-activation
branch
from
66e37d0 to
86d83d5
Compare
Member
Author
4 tasks
marcoscaceres
approved these changes
Nov 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a bunch of other tests redundant, as they're also calling
requestFullscreen() twice, and should all fail in exactly the same way.
element-request-fullscreen-same-manual.html is also converted to ensure
that a second call in a new click does work, to ensure the failure isn't
because the element is the same as the fullscreen element.
Follows whatwg/fullscreen#153.