fix(create): add @rsbuild/core/types reference to project template#8574
Open
Jack-sh1 wants to merge 2 commits into
Open
fix(create): add @rsbuild/core/types reference to project template#8574Jack-sh1 wants to merge 2 commits into
Jack-sh1 wants to merge 2 commits into
Conversation
- Fix "unkown" -> "unknown" in streaming error message - Fix "preResovled" -> "preResolved" in comment - Fix "createRemixReuqest" -> "createRemixRequest" function name
The generated modern-app-env.d.ts is missing the @rsbuild/core/types reference, causing TypeScript errors for import.meta.env.DEV and other Rsbuild built-in environment variables. Closes web-infra-dev#8522
|
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The generated
modern-app-env.d.tstemplate is missing the@rsbuild/core/typestriple-slash reference, causing TypeScript errors forimport.meta.env.DEVand other Rsbuild built-in environment variables in newly created projects.This PR adds the missing reference:
/// <reference types='@modern-js/app-tools/types' /> +/// <reference types='@rsbuild/core/types' /> Closes #8522Related Links
@rsbuild/core/typestype reference in project template #8522Checklist
pnpm run change.