Conversation
…keCredentialGenerator Include hybrid, internal and smart-card transports in the fake credential pool so generated credentials are indistinguishable from real ones. Replace random generation with a deterministic HMAC-based seed derived from the username and a server secret, ensuring stable responses across requests without relying on cache.
Use CacheItemPoolInterface with nullOnInvalid() instead of hardcoded null so the cache is actually used when available in the container.
…coding standards Use CacheItemPoolInterface with nullOnInvalid() instead of hardcoded null so the cache is actually used when available in the container. Apply coding standards fixes across the codebase.
…and service classes - Removed duplicate function imports and organized them in multiple denormalizer classes including CredentialRecordDenormalizer, ExtensionDescriptorDenormalizer, and others. - Ensured consistent use of function imports such as `array_key_exists`, `assert`, `count`, and `in_array`. - Updated import statements in various service classes like DistantResourceMetadataService, FidoAllianceCompliantMetadataService, and others for better clarity and maintainability. - Cleaned up unused imports in test files and ensured proper organization of function imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hybrid,internalandsmart-cardtransports to the fake credential pool so generated credentials cover the same transport types as real onesrandom_int/random_bytes) generation with a deterministic seed derived from the username and a server secret, ensuring stable responses across requests even without cachekernel.secretinto the Symfony service registration as seedTest plan
CacheItemPoolInterfaceinjection still works (BC)