Open
Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
b05b0f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9d5b68bf.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-add-rpcs-to-mockwave.waveterm.pages.dev |
Copilot
AI
changed the title
[WIP] Add RPCs to mockwaveenv.ts
Add preview mock support for secrets RPCs
Mar 15, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
The changes implement mock versions of the secrets-related RPC commands for the preview/test environment. The implementation:
No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preview mock
WaveEnvwas missing the secrets RPC surface used by config/secrets flows. This adds mock implementations for the four secrets commands so preview and test environments can exercise secrets behavior without a backend.Added mock secrets RPC handlers
GetSecretsLinuxStorageBackendCommandGetSecretsNamesCommandGetSecretsCommandSetSecretsCommandBacked secrets RPCs with in-memory state
makeMockRpcSetSecretsCommandnow supports both upsert and delete (null=> remove)GetSecretsNamesCommandreturns sorted secret names for stable behaviorGetSecretsCommandreturns only requested keys that existGetSecretsLinuxStorageBackendCommandreturns"libsecret"on Linux previews and""elsewhereKept the change scoped to preview/mock behavior
Added focused coverage
frontend/preview/mock/mockwaveenv.test.tsto cover set/get/list/delete semantics and Linux backend reporting📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.