Add WebViewEnv and wire web preview to the mock WaveEnv contract#3064
Open
Add WebViewEnv and wire web preview to the mock WaveEnv contract#3064
Conversation
Co-authored-by: sawka <2722291+sawka@users.noreply.github.com>
Deploying waveterm with
|
| Latest commit: |
c2fe9d4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d514e4df.waveterm.pages.dev |
| Branch Preview URL: | https://copilot-add-webview-env-mock.waveterm.pages.dev |
Copilot
AI
changed the title
[WIP] Add mock environment for webview widget
Add WebViewEnv and wire web preview to the mock WaveEnv contract
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The webview preview existed, but the webview feature was still reading key dependencies from global helpers instead of a narrowed
WaveEnv, which left the preview without a proper mock environment contract. This change introduces a dedicatedWebViewEnvand routes the webview model/view through it so preview/test mocks can supply the same dependencies explicitly.WaveEnv narrowing for webview
frontend/app/view/webview/webviewenv.tselectron:openExternal,getWebviewPreload,clearWebviewStorage,getConfigDir,setWebviewFocusrpc:FetchSuggestionsCommand,SetMetaCommand,SetConfigCommandwos,createBlockgetSettingsKeyAtom("web:defaulturl" | "web:defaultsearch")getBlockMetaKeyAtom("web:hidenav" | "web:useragenttype" | "web:zoom" | "web:partition")WebView model/view now consume env-provided dependencies
WebViewModelnow stores and useswaveEnvinstead of reaching into global singletons for WOS, settings, block meta, RPC, and Electron APIs.web:defaultsearch,web:zoom, andweb:partitionfromuseWaveEnv<WebViewEnv>().Preview/mock behavior aligned with production semantics
{query}, matching the webview search-template substitution logic.SetConfigCommandbehavior so settings updates remain observable throughgetSettingsKeyAtom, which is required for env-driven preview behavior.pinnedurlvianull, matching the mock RPC meta-deletion semantics.Focused coverage
📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.