Fix nostdout() to restore sys.stdout after exceptions#558
Merged
wasserth merged 1 commit intowasserth:masterfrom Mar 30, 2026
Merged
Fix nostdout() to restore sys.stdout after exceptions#558wasserth merged 1 commit intowasserth:masterfrom
wasserth merged 1 commit intowasserth:masterfrom
Conversation
nostdout() replaced sys.stdout with a DummyFile but only restored it on normal exit. If an exception occurred during the yield (e.g., a failing nnU-Net prediction), sys.stdout remained suppressed for the rest of the process. Use try/finally to guarantee restoration. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nostdout()context manager replacedsys.stdoutwith aDummyFilebut only restored it on normal exit. If an exception was raised during theyield(e.g., a failing nnU-Net prediction),sys.stdoutremained permanently suppressed for the rest of the process.nnunet.py(lines 565 and 592), so a prediction failure could leave the process mute — no furtherprint()output would be visible.yieldintry/finallyto guaranteesys.stdoutis restored.Test plan
nostdout()block and verify that subsequentprint()calls produce output