Fix unreasonable code: retry logic, DOM checks, variable declarations#10
Fix unreasonable code: retry logic, DOM checks, variable declarations#10
Conversation
- Fix retry logic in `main_run.py` to correctly retry the `original_request` 3 times instead of returning an error on the first exception. - Fix DOM element existence check in `content.js` from `=== undefined` to `=== null`, as `document.getElementById` returns `null` if the element does not exist. - Declare multiple variables with `let` in `content.js` and `popup.js` to prevent polluting the global scope or causing bugs. Co-authored-by: wa008 <29834520+wa008@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR scans the codebase for unreasonable code and applies intelligent fixes to improve stability and reliability.
Key changes:
main_run.py(Broken Retry Logic): Fixed a fake retry loop. Previously, thetry-exceptblock returned a 500 error immediately on the first exception, completely defeating thefor i in range(3)loop. The patch correctly catches the exception, allows the loop to continue retrying, and only returns the error if all 3 attempts fail.content.js(DOM Check): Changeddocument.getElementById("my_overlay") === undefinedto=== null. This is an essential bug fix becausegetElementByIdreturnsnull(notundefined) if an element is not found.content.js&popup.js(Variable Declarations): Addedletto multiple undeclared variables (e.g.,res_json,key,translatedText,extensionOn,language, etc.). This prevents the accidental creation of global variables.PR created automatically by Jules for task 11083860701229918613 started by @wa008