feat(cardshed): scaffold apps/ui + design system (M1+M2)#156
Merged
Conversation
M1 (SCAFFOLD apps/ui)
- Mirror @lab/ll-RELIQUARY/apps/ui tree at @lab/ll-CARDSHED/apps/ui.
- Vite 5.4 + React 18 + TS 5.7 + Tailwind v4; port 4343.
- Deps per PRP 3 M1: add partysocket, zod, immer, zustand,
framer-motion, Radix dialog/tabs/tooltip, tailwind-merge, clsx,
@cardshed/core via file:../core; drop pixi.js + react-router-dom.
- Boot screen calls createDeck() from @cardshed/core to smoke-prove
the workspace link; renders "CARD SHED — MVP M1" + "deck: 52 cards".
- tsconfig noEmit:true so tsc -b is type-check only; Vite owns emit.
- Minimal flat ESLint config (--max-warnings 0 green).
M2 (STORYBOARD + DESIGN SYSTEM)
- docs/STORYBOARD.md §1–§7: premise, three-player user journey,
screen inventory (S01–S10 MVP subset), engine-contract mapping,
full ASCII wireframes for every MVP screen, Stitch provenance log.
- .stitch/DESIGN.md regenerated as DS-1 from a single canonical
Stitch run (S03 Table) — full token blocks for color, typography,
spacing, radius, elevation, motion, component vocabulary, plus a
drop-in Tailwind v4 @theme block.
- docs/DECISIONS/2026-05-21-stitch-run-1.md records why one screen
anchored the system (warm-session silent-drop invariant), what
Stitch chose, and the decision criteria for any future DS bump.
- .stitch/designs/S03-table.{html,png} kept as the visual source-of-
truth for DS-1.
Evidence
- dogfood-output/20260521T193040Z/m1-boot/ — agent-browser screenshot
at 1440×900 + report.md confirming clean console + working core link.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
|
Caution Review failedPull request was closed or merged during review 📝 WalkthroughWalkthroughScaffolds the CARD SHED React/Vite UI application with design system integration. Includes complete MVP storyboard (9 screens with wireframes), design system document (DS-1) with tokenized palette/typography/geometry, reference table screen, Vite/TypeScript/ESLint configuration, React bootstrap, and Tailwind theme synchronization; M1 boot acceptance report confirms build and boot screen rendering. ChangesCARD SHED MVP Storyboard, Design System, and UI App
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #148. First sub-issue of umbrella #146 (PRP 3 §A M1–M17).
Summary
@cardshed/coreviafile:../core). Boot screen smoke-importscreateDeck()to prove the workspace link works.docs/STORYBOARD.mdcovers premise, three-player user journey, screen inventory, engine contract, and ASCII wireframes for all 10 MVP screens..stitch/DESIGN.mdregenerated as DS-1 from a single canonical Stitch run (S03 Table) — Stitch project `projects/4083518914509964664` — anchored to the warm-session silent-drop invariant. Per-screen mockups are deferred to M3+ where each milestone owns its own Stitch session.Acceptance gates (PRP 3 §M1 + §M2)
Evidence
Why one Stitch screen for the whole design system
Project memory invariant: "Stitch warm-session silent-drop" — first `generate_screen_from_text` per Claude Code session succeeds; calls #2+ time out at ~2 min and never appear in `list_screens`. Restart-only unblock. To produce DS-1 in one session, the call was made against S03 Table (the canonical in-match screen) since it exercises the full visual vocabulary: opponent chips, state chips, recessed felt panel, card states (idle/selected/legal/illegal/ringed-target), action pills, helper text, brand-mark, header icon buttons. Per-screen mockups land at M3+ where each Stitch run gets its own clean session. See `docs/DECISIONS/2026-05-21-stitch-run-1.md` for the full rationale + token deltas.
What is NOT in this PR
Test plan
Next (post-merge → M3)
Run `Skill: stitch-design` in a fresh session to produce `docs/SCREENS/main-menu.md` for S01 (M3). Each subsequent milestone owns one Stitch session per the warm-session-drop constraint.
Summary by CodeRabbit
Release Notes
New Features
Documentation