docs(repo): name cross-slice read-only import pattern (#264)#265
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
Summary
docs/_base/ARCHITECTURE.md, naming a convention now used twice in production (explainability/service.py:57,forecasting/service.pyper PRP-31).Closes #264.
Why
The pattern has shipped twice but is nowhere documented. Without naming it in ARCHITECTURE.md, the next maintainer encountering a cross-slice import discussion has to re-derive the rationale from PR history. Source:
.agents/system-reviews/prp-31-mlzoo-d-frontend-registry-explainability-review.md§ "System Improvement Actions" → third action.Validation gates (local)
uv run ruff check . && uv run ruff format --check .✅uv run mypy app/✅ (276 source files)uv run pyright app/✅ (0 errors, 68 pre-existing warnings)uv run pytest -m "not integration"✅ (1423 passed)Test plan
dev(Lint & Format, Type Check, Test, Migration Check)