Skip to content

docs(repo): name cross-slice read-only import pattern (#264)#265

Merged
w7-mgfcode merged 1 commit into
devfrom
docs/cross-slice-import-pattern
May 20, 2026
Merged

docs(repo): name cross-slice read-only import pattern (#264)#265
w7-mgfcode merged 1 commit into
devfrom
docs/cross-slice-import-pattern

Conversation

@w7-mgfcode
Copy link
Copy Markdown
Owner

Summary

  • New subsection "Cross-slice read-only import pattern" in docs/_base/ARCHITECTURE.md, naming a convention now used twice in production (explainability/service.py:57, forecasting/service.py per PRP-31).
  • Text is verbatim from the PRP-31 system review's DECISIONS LOCKED block.

Closes #264.

Why

The pattern has shipped twice but is nowhere documented. Without naming it in ARCHITECTURE.md, the next maintainer encountering a cross-slice import discussion has to re-derive the rationale from PR history. Source: .agents/system-reviews/prp-31-mlzoo-d-frontend-registry-explainability-review.md § "System Improvement Actions" → third action.

Validation gates (local)

  • uv run ruff check . && uv run ruff format --check .
  • uv run mypy app/ ✅ (276 source files)
  • uv run pyright app/ ✅ (0 errors, 68 pre-existing warnings)
  • uv run pytest -m "not integration" ✅ (1423 passed)

Test plan

  • CI checks green on dev (Lint & Format, Type Check, Test, Migration Check)
  • One reviewer
  • Merge via the web UI

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b69be97d-4d2c-4604-96b9-fe8c69df5ea8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/cross-slice-import-pattern

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @w7-mgfcode, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant