Skip to content

fix(ui): chart series render black — drop hsl() wrapper on oklch chart vars (#149) #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
w7-mgfcode merged 1 commit into from
May 18, 2026
Merged

fix(ui): chart series render black — drop hsl() wrapper on oklch chart vars (#149) #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions frontend/src/components/charts/backtest-folds-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,13 @@ interface BacktestFoldsChartProps {
className?: string
}

// The --chart-N vars are complete oklch() colours (Tailwind 4 / shadcn v4);
// reference them directly — wrapping in hsl() produces invalid CSS (black).
const metricColors: Record<string, string> = {
mae: 'hsl(var(--chart-1))',
smape: 'hsl(var(--chart-2))',
wape: 'hsl(var(--chart-3))',
bias: 'hsl(var(--chart-4))',
mae: 'var(--chart-1)',
smape: 'var(--chart-2)',
wape: 'var(--chart-3)',
bias: 'var(--chart-4)',
}

const metricLabels: Record<string, string> = {
Expand Down
6 changes: 4 additions & 2 deletions frontend/src/components/charts/time-series-chart.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,16 @@ export function TimeSeriesChart({
height = 300,
className,
}: TimeSeriesChartProps) {
// The --chart-N vars are complete oklch() colours (Tailwind 4 / shadcn v4);
// reference them directly — wrapping in hsl() produces invalid CSS (black).
const chartConfig: ChartConfig = {
[actualKey]: {
label: 'Actual',
color: 'hsl(var(--chart-1))',
color: 'var(--chart-1)',
},
[predictedKey]: {
label: 'Predicted',
color: 'hsl(var(--chart-2))',
color: 'var(--chart-2)',
},
}

Expand Down