Fix iframe promise rejection in unloading document cleanup#268
Open
marcoscaceres wants to merge 2 commits into
Open
Fix iframe promise rejection in unloading document cleanup#268marcoscaceres wants to merge 2 commits into
marcoscaceres wants to merge 2 commits into
Conversation
Resolves specification inconsistency where iframe documents with pending orientation lock promises were not having their promises rejected during document unloading. The previous algorithm would abort cleanup steps for non-top-level documents before rejecting pending promises. This fix separates two concerns: 1. Promise rejection (happens for ALL documents including iframes) 2. Screen orientation unlocking (only happens for top-level documents) This aligns the specification with the Web Platform Test expectations in active-lock.html which expects iframe lock promises to be rejected with AbortError when the iframe document is unloaded.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes unloading behavior so that iframe documents with pending orientation lock promises have those promises rejected, aligning spec text with WPT expectations.
- Reject and nullify the current lock promise for all documents (including iframes) before aborting steps for non-top-level documents.
- Leave screen orientation unlocking only for top-level documents.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves specification inconsistency where iframe documents with pending orientation lock promises were not having their promises rejected during document unloading.
The previous algorithm would abort cleanup steps for non-top-level documents before rejecting pending promises. This fix separates two concerns:
This aligns the specification with the Web Platform Test expectations in active-lock.html which expects iframe lock promises to be rejected with AbortError when the iframe document is unloaded.
Closes #257
The following tasks have been completed:
Implementation commitment:
Preview | Diff