Editorial: Fix pre-lock conditions algorithm structure#267
Merged
Conversation
Move pre-lock conditions definition after algorithm steps and integrate as optional step 4 for clarity. Addresses feedback about confusing interleaved MUST/MAY structure.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Clarifies the Screen Orientation locking algorithm by isolating and formalizing “pre-lock conditions” to improve readability and normative flow.
- Moves the “pre-lock conditions” definition out of the interleaved intro paragraph.
- Adds an explicit optional algorithm step that rejects when pre-lock conditions are required but unmet.
- Rewords and links the definition section to relevant interactions (app manifest and fullscreen).
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Closed
|
This makes it super clear to me, thanks! |
bvandersloot-mozilla
approved these changes
Oct 17, 2025
marcoscaceres
commented
Oct 21, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
marcoscaceres
commented
Oct 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move pre-lock conditions definition after algorithm steps and integrate as optional step 4 for clarity. Addresses feedback about confusing interleaved MUST/MAY structure.
Closes #261
Preview | Diff