End editing on PointerPress#357
Open
Mangepange wants to merge 3 commits into
Open
Conversation
w-ahmad
requested changes
May 7, 2026
w-ahmad
approved these changes
May 12, 2026
Owner
w-ahmad
left a comment
w-ahmad
left a comment
There was a problem hiding this comment.
Looks good to me, Thanks for the contribution @Mangepange!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #350
The current cell edit must be ended already in OnPointerPressed.
I'm not 100% sure if it also must be done in OnTapped, but I guess that when using touch, you don't get any Pointer events, but still Tap/DoubleTap so I extracted a method that could be called both from OnPointerPressed and OnTapped.
I also removed some redundant async method signatures.