Closed
Conversation
feat: export icons
feat: migrate icons from helpcenter and devportal
Fix/icon name
fix: VTEXDevPortalIcon
fix: VTEXLogoFooter
styles: update word-break behavior
Contributor
|
Testei essa PR atualizando o "@vtexdocs/components": "https://github.com/vtexdocs/components.git#fix/sidebar"Depois executei Problema EncontradoA aplicação falha ao renderizar com o seguinte erro: Parece que o projeto helpcenter importa SugestãoAdicionar os exports dos ícones que estão faltando em export { default as CopyIcon } from './components/icons/copy-icon'
export { default as SearchIcon } from './components/icons/search-icon'Assim que corrigido, posso re-testar as mudanças de comportamento da sidebar. |
…into fix/sidebar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes sidebar styling issues affecting navigation on smaller screens.
Now, the sidebar stays open regardless of screen size, and users can close it whenever they want. The solution aligns with the issue raised by the design team: vtexdocs/helpcenter#365
Types of changes