22 end of pipeline service call to state machine#23
Merged
ashishagain merged 18 commits intomainfrom Apr 29, 2026
Merged
Conversation
…lling Subscribes to /classification_output (std_msgs/UInt8), counts consecutive Class 1 detections, and calls pipeline_inspection_fsm/pipeline_finished (std_srvs/Trigger) once the configurable threshold is reached.
kluge7
requested changes
Apr 24, 2026
…y vortex_utils_ros
Removed commented-out section for yasmin dependency.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
========================================
- Coverage 8.72% 8.40% -0.33%
========================================
Files 42 44 +2
Lines 1674 1738 +64
Branches 340 346 +6
========================================
Hits 146 146
- Misses 1442 1506 +64
Partials 86 86
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
kluge7
requested changes
Apr 24, 2026
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we reach the end of the pipeline, our model outputs a std_msgs/msg/u_int8 (depending on if it is the end of the pipeline or not). This should trigger a service call to the state machine telling it that we are done following the pipeline. The task is to make a ROS node which subscribes to this topic (std_msgs/msg/u_int8) and after having gotten X amount of consecutive detections, send out a service call to the state machine (contact @CurryMonsters for details on what service call). Contact either @kluge7 or @gardeg for information about the data the end-of-pipeline detector node outputs.
Related issues:
vortexntnu/vortex-pipeline-detection#17
https://github.com/vortexntnu/perception-auv/issues/50When we reach the end of the pipeline, our model outputs a std_msgs/msg/u_int8 (depending on if it is the end of the pipeline or not). This should trigger a service call to the state machine telling it that we are done following the pipeline. The task is to make a ROS node which subscribes to this topic (std_msgs/msg/u_int8) and after having gotten X amount of consecutive detections, send out a service call to the state machine (contact @CurryMonsters for details on what service call). Contact either @kluge7 or @gardeg for information about the data the end-of-pipeline detector node outputs.
Related issues:
vortexntnu/vortex-pipeline-detection#17
vortexntnu/perception-auv#50