Skip to content

22 end of pipeline service call to state machine#23

Merged
ashishagain merged 18 commits intomainfrom
22-end-of-pipeline-service-call-to-state-machine
Apr 29, 2026
Merged

22 end of pipeline service call to state machine#23
ashishagain merged 18 commits intomainfrom
22-end-of-pipeline-service-call-to-state-machine

Conversation

@ashishagain
Copy link
Copy Markdown
Contributor

When we reach the end of the pipeline, our model outputs a std_msgs/msg/u_int8 (depending on if it is the end of the pipeline or not). This should trigger a service call to the state machine telling it that we are done following the pipeline. The task is to make a ROS node which subscribes to this topic (std_msgs/msg/u_int8) and after having gotten X amount of consecutive detections, send out a service call to the state machine (contact @CurryMonsters for details on what service call). Contact either @kluge7 or @gardeg for information about the data the end-of-pipeline detector node outputs.

Related issues:
vortexntnu/vortex-pipeline-detection#17
https://github.com/vortexntnu/perception-auv/issues/50When we reach the end of the pipeline, our model outputs a std_msgs/msg/u_int8 (depending on if it is the end of the pipeline or not). This should trigger a service call to the state machine telling it that we are done following the pipeline. The task is to make a ROS node which subscribes to this topic (std_msgs/msg/u_int8) and after having gotten X amount of consecutive detections, send out a service call to the state machine (contact @CurryMonsters for details on what service call). Contact either @kluge7 or @gardeg for information about the data the end-of-pipeline detector node outputs.

Related issues:
vortexntnu/vortex-pipeline-detection#17
vortexntnu/perception-auv#50

…lling

Subscribes to /classification_output (std_msgs/UInt8), counts consecutive
Class 1 detections, and calls pipeline_inspection_fsm/pipeline_finished
(std_srvs/Trigger) once the configurable threshold is reached.
@ashishagain ashishagain linked an issue Apr 22, 2026 that may be closed by this pull request
@ashishagain ashishagain requested a review from kluge7 April 22, 2026 15:52
Comment thread mission/tacc/pipeline_inspection/pipeline_end_detector/package.xml Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 8.40%. Comparing base (ec1bcaa) to head (8ff5b56).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
...ne_end_detector/src/pipeline_end_detector_node.cpp 0.00% 57 Missing ⚠️
...line_inspection/pipeline_end_detector/src/main.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #23      +/-   ##
========================================
- Coverage   8.72%   8.40%   -0.33%     
========================================
  Files         42      44       +2     
  Lines       1674    1738      +64     
  Branches     340     346       +6     
========================================
  Hits         146     146              
- Misses      1442    1506      +64     
  Partials      86      86              
Flag Coverage Δ
unittests 8.40% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...line_inspection/pipeline_end_detector/src/main.cpp 0.00% <0.00%> (ø)
...ne_end_detector/src/pipeline_end_detector_node.cpp 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ashishagain ashishagain requested a review from kluge7 April 28, 2026 22:07
Copy link
Copy Markdown
Contributor

@kluge7 kluge7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashishagain ashishagain merged commit c744537 into main Apr 29, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End-of-pipeline service call to state machine

2 participants