Reduce monomorphization by dispatching over unsigned integer widths#8110
Open
joseph-isaacs wants to merge 1 commit into
Open
Reduce monomorphization by dispatching over unsigned integer widths#8110joseph-isaacs wants to merge 1 commit into
joseph-isaacs wants to merge 1 commit into
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR reduces code bloat from generic monomorphization by dispatching over unsigned integer widths (4 types) instead of all signed and unsigned integer types (8 types) in hot paths where values are known to be non-negative.
The key insight is that offsets, indices, lengths, and similar values are always non-negative. By reinterpreting signed buffers as their unsigned counterparts (same width, identical bit patterns), we can dispatch over 4 unsigned widths instead of 8 integer types. For nested matches (e.g., offset type × size type), this reduces the cross-product from 8×8=64 to 4×4=16 monomorphizations.