Skip to content

fix(supabase)http https#396

Merged
cuericlee merged 4 commits intovolcengine:mainfrom
sjcsjcsjc:main
Apr 27, 2026
Merged

fix(supabase)http https#396
cuericlee merged 4 commits intovolcengine:mainfrom
sjcsjcsjc:main

Conversation

@sjcsjcsjc
Copy link
Copy Markdown
Contributor

@sjcsjcsjc sjcsjcsjc commented Apr 27, 2026

No description provided.

@YIDWang
Copy link
Copy Markdown

YIDWang commented Apr 27, 2026

LGTM

cuericlee
cuericlee approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cuericlee cuericlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cuericlee
Copy link
Copy Markdown
Collaborator

cuericlee commented Apr 27, 2026

Review Notes

  • 🔴 _endpoint_url() directly uses address["domain"] → may raise KeyError if missing
  • 🟡 port=None defaults to HTTP → many cloud services require HTTPS without explicit port
  • 🟡 Removed volces.com public-domain hack → relies solely on address_type, needs validation
  • 🟢 Core logic changes lack unit test coverage

@sjcsjcsjc
Copy link
Copy Markdown
Contributor Author

sjcsjcsjc commented Apr 27, 2026

fixed

cuericlee
cuericlee approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@cuericlee cuericlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cuericlee cuericlee merged commit 93ccc90 into volcengine:main Apr 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cuericlee cuericlee cuericlee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjcsjcsjc @YIDWang @cuericlee