Fixing misalignment crash: width and height of bbox should be a multi…#11
Open
r-kellermann wants to merge 1 commit intovojirt:masterfrom
Open
Fixing misalignment crash: width and height of bbox should be a multi…#11r-kellermann wants to merge 1 commit intovojirt:masterfrom
r-kellermann wants to merge 1 commit intovojirt:masterfrom
Conversation
…ple of (cell_size * 2)
|
enen if I change code according to your commit, hog heap crashing problem still exist...any otther idea to solve it ? thank you |
|
#10 : I ended up using https://github.com/joaofaro/KCFcpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ple of (cell_size * 2)
Proposed ix for: #10
Piotr's hog SSE calculations require the inputs to be 16 bytes aligned, or it crashes when trying to release R1 and R2 in gradientMex.cpp::fhog.
The relevant propagated parameters are the bounding box width and height that should be a multiple of (cell_size * 2).
You can see that when profiling the existing code with Valgrind, it complains on invalid read / writes. With the proposed fix those errors are gone.