binwalk: update to 3.1.0.#60668
Open
rayfadh wants to merge 1 commit into
Open
Conversation
rayfadh
force-pushed
the
binwalk
branch
3 times, most recently
from
ba72c31 to
a7d0560
Compare
Contributor
Author
|
Just a simple test. |
Contributor
Author
|
|
|
||
| post_extract() { | ||
| vsed -i -e 's;/etc/bash_completion.d/%s;%s.bash;' setup.py | ||
| _setup_env() { |
Member
There was a problem hiding this comment.
do this instead (adjust for specific cc version)
void-packages/srcpkgs/sequoia-sq/template
Lines 20 to 22 in 4505b7b
Contributor
Author
There was a problem hiding this comment.
Turns out it doesn't need the CC workaround at all to build. IIRC it was for cross-compilation, CMIIW.
rayfadh
force-pushed
the
binwalk
branch
2 times, most recently
from
9f2eb3f to
fe40585
Compare
| pre_build() { | ||
| # strip kaleido binary download feature from plotly | ||
| sed -i 's/features = \["kaleido", "kaleido_download"\]//' Cargo.toml | ||
| cargo vendor vendor |
Member
There was a problem hiding this comment.
why is cargo vendor needed?
Contributor
Author
There was a problem hiding this comment.
Oh right, I'm sorry. Just realized I was looking the main branch's Cargo.toml, will strip the whole pre_build() part.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Testing the changes
Local build testing
@Duncaen, I updated binwalk to 3.1.0, just wanna let ya know.