Conversation
✅ Deploy Preview for upset2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
Author
|
Deploy preview seems to be working, with some implementation issues. Firstly, the axis labels are being cut off, likely due to a fixed width view Second, the preview when adding a chart is blank |
Member
Author
|
Preview data is showing correctly, but the charts need more padding 
|
Member
Author
Locally, the charts have correct width after the buffer changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does this PR close any open issues?
Closes none
Give a longer description of what this PR addresses and why it's needed
This migrates react-vega to 8.0.0 which now uses vega-embed
Provide pictures/videos of the behavior before and after these changes (optional)
Have you added or updated relevant tests?
Have you added or updated relevant documentation?
Are there any additional TODOs before this PR is ready to go?
TODOs: