Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to stabilize CI/builds by making libpcap-dependent binaries/plugins conditional on detected libpcap headers/libraries, and by adjusting CI and link dependencies so builds don’t fail when pcap isn’t available.
Changes:
- Gate building and installing
vde_pcapplugandpdumponCAN_MAKE_VDE_PCAPinstead of the rawENABLE_PCAPoption. - Add a header check for
pcap.hand use it (withPCAP_LIBRARY) to computeCAN_MAKE_VDE_PCAP, emitting a warning when pcap is enabled but unavailable. - Update CI workflow configuration and Linux dependencies; update
vde_pcappluglink libraries.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/vde_switch/plugins/CMakeLists.txt |
Build/install pdump only when CAN_MAKE_VDE_PCAP is true. |
src/CMakeLists.txt |
Link vde_pcapplug with vdecommon and install it only when CAN_MAKE_VDE_PCAP is true. |
CMakeLists.txt |
Add pcap.h detection and compute CAN_MAKE_VDE_PCAP from header+library presence with a warning fallback. |
.github/workflows/ci.yml |
Update triggers and dependency install/checkout steps for CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.