Adding support for Vault JWT Authentication#11
Open
JamesBelchamber wants to merge 1 commit intovinted:masterfrom
Open
Adding support for Vault JWT Authentication#11JamesBelchamber wants to merge 1 commit intovinted:masterfrom
JamesBelchamber wants to merge 1 commit intovinted:masterfrom
Conversation
Co-authored-by: Mania Kazemzadeh <mania@substruct.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Vault JWT Authentication support, which is an alternative to approle authentication. When
VAULT_TOKENis set,VAULT_APPROLE_ROLE_IDandVAULT_APPROLE_SECRET_IDdo not need to be set. Note that this PR has conflicts with #10, specifically intest/integration_test.go- once one is merged the other will need to be updated.As per #9 and #10, this is work done for a client that I'm now offering upstream 🙂