Removes relative_permalinks that are no longer supported by jekyll#18
Open
lucasmbraz wants to merge 3 commits into
Open
Removes relative_permalinks that are no longer supported by jekyll#18lucasmbraz wants to merge 3 commits into
lucasmbraz wants to merge 3 commits into
Conversation
|
I just wanted to say thank you for your time and effort to work on this update to this template. It's pretty much perfect for a project I'm working on and I've tested and validated that your changes work (at least locally) do the trick. 🙏🏻Hopefully it gets merged so other folks can use it too. |
Author
|
Thanks for the feedback. I'm really glad it helped you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I really liked your theme but when I tried it jekyll couldn't build it because of relative_permalinks=true on the config file. Also, github pages no longer uses redcarpet and doesn't support pygments highlighter.
This is my attempt at fixing it. It seems to work for me but I'm not a web dev so I'm not very sure.
I followed this to fix the broken links http://downtothewire.io/2015/08/15/configuring-jekyll-for-user-and-project-github-pages/