feat: Phase 2 — expand world to 7 rooms with items and narrative#5
Merged
Conversation
Add 5 rooms to create_map() (Library, ThroneRoom, Kitchen, Cellar, Barracks)
with bidirectional connections forming a small castle layout:
[Armoury] — East — [Barracks]
↕
[Library] ← [Grand Hall] → [Throne Room]
↕
[Kitchen]
↕
[Cellar]
Place items that hint at a puzzle chain: old tome (Library), iron key
(Kitchen), silver pendant (Cellar). Update golden chalice use_message to
hint it belongs on the throne. Convert chalice to designated initialiser
syntax to match project style.
Add 16 new Map tests covering all connections, bidirectional traversal,
and item placement. All 96 tests pass.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create_map()from 2 rooms to 7, forming a small castle layout with a narrative through-lineuse_messageto hint it belongs on the throne (sets up the Phase 3 win condition), and converts it to designated initialiser syntaxopposite_direction()mechanism — no structural changes requiredTest plan
Map.test.cppcovering all new connections, bidirectional traversal, item placement, and empty roomsctest)just clang-tidy— no warningsjust format— no changes after formatting<__ostream/basic_ostream.h>) is a known platform artefact; Linux CI will be clean🤖 Generated with Claude Code