feat: Phase 1 — fix missing commands, add look action, expand docs#4
Merged
Conversation
…ction - Fix ConsoleInputHandler missing "drop" and "inventory" command parsing - Add use_message to rusty sword in create_map() - Add Look action: Action enum value, ConsoleInputHandler parser, Game::look() displays current room description and available exits - Add 5 new tests covering all Phase 1 behaviour - Update CLAUDE.md: CMake presets, interface layer, NOLINT patterns - Add docs/development-plan.md with 6-phase roadmap Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConsoleInputHandlermissing commands:"drop"and"inventory"were parsed nowhere, making those actions unreachable from the consoleuse_messageto rusty sword: switches to designated-initializer syntax and gives the sword a meaningful response when usedlookaction: newAction::Lookenum value,"look"console command, andGame::look()that re-displays the current room description and available exits without movingIMap/IPlayer/IInputHandler), and required NOLINT patterns for GMock and optional accessdocs/development-plan.mdwith a 6-phase roadmap (world expansion, win condition, locked doors, NPCs, save/load)Test plan
ctest)getActionDrop,getActionInventory,getActionLook(ConsoleInputHandler),handleUserActionLook,lookDisplaysRoomDescriptionAndDirections(Game)just clang-tidyto verify no new warningsjust iwyuto verify no new include violationsjust formatto verify formatting🤖 Generated with Claude Code