Handle message deserialization failures gracefully to prevent poison message blocking#79
Closed
sergey-elmanov wants to merge 1 commit into
Closed
Conversation
…message blocking.
sergey-elmanov
force-pushed
the
fix-poison-message-rollback
branch
from
b3fddbd to
8e6e995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves error handling during message deserialization in the consumer code. The main change is that if a message fails to deserialize (for example, due to corrupted data), the error is caught and handled gracefully: the problematic row is skipped, allowing the consumer to continue processing other messages. This prevents a single "poison" message from blocking the queue.
Error handling and robustness improvements:
ConsumerSchemaHelpers.readwith a try-catch block. If deserialization fails, aMessageDeserializationExceptionis thrown, including the message ID for easier debugging. [1] [2] [3]ConnectionAwareDatabaseConsumer, added logic to catchMessageDeserializationExceptionduring message retrieval. When caught, the row is skipped, and a comment explains that this allows the queue to continue processing and avoids blocking on poison messages.MessageDeserializationExceptioninConnectionAwareDatabaseConsumer.ktto support the new error handling.