Skip anchors better#4899
Open
faithokamoto wants to merge 5 commits intomasterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog Entry
To be copied to the draft changelog by merger:
Description
Fixes the calculation called out in #4701. I added another parameter in the process because I was doing a parameter search. Didn't take out out again mostly because I didn't want to bother. It's not hurting anyone.
Fiddling with the parameters revealed no clear wins on HiFi reads, and on R10 reads the best I got was about an extra bp/read which was aligned as a match (plus 0.5bp/read less softclips), with no real compromises elsewhere. (Google Sheets) Which is technically a win but is so small that I'm not bothering updating the parameters. So the PR is just the bugfix.