Skip to content

rm token position #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wassname wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rm token position #70

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions repeng/control.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,24 +166,7 @@ def forward(self, *args, **kwargs):

norm_pre = torch.norm(modified, dim=-1, keepdim=True)

# we should ignore the padding tokens when doing the activation addition
# mask has ones for non padding tokens and zeros at padding tokens.
# only tested this on left padding
if "position_ids" in kwargs:
pos = kwargs["position_ids"]
zero_indices = (pos == 0).cumsum(1).argmax(1, keepdim=True)
col_indices = torch.arange(pos.size(1), device=pos.device).unsqueeze(0)
target_shape = modified.shape
mask = (
(col_indices >= zero_indices)
.float()
.reshape(target_shape[0], target_shape[1], 1)
)
mask = mask.to(modified.dtype).to(modified.device)
else:
mask = 1.0

modified = self.params.operator(modified, control * mask)
modified = self.params.operator(modified, control)

if self.params.normalize:
norm_post = torch.norm(modified, dim=-1, keepdim=True)
Expand Down