Pink Maridia shinesparks: split speed and general cleanup#2756
Pink Maridia shinesparks: split speed and general cleanup#2756osse101 merged 3 commits intovg-json-data:masterfrom
Conversation
| {"and": [ | ||
| "HiJump", | ||
| "canSpeedyJump", | ||
| "canShinechargeMovementComplex", |
There was a problem hiding this comment.
9 frames is about canShinechargeMovementTricky so 11 frames is a little nicer than that but not much.
If you really want to minimize damage without gravity jump or a snail, you can go 2->5->9. Just speed would have a shorter shinespark. Turning off gravity doesn't have to shinespark.
There was a problem hiding this comment.
honestly not sure how i feel about avoiding gravity jumps. We have made some effort to avoid them, but so inconsistently. I think I'll not worry about it as much now.
There was a problem hiding this comment.
This just reads as adding complex logic when a gravity jump is easier and saves health.
It'd just be this branch that's excessive.
| {"useFlashSuit": {}}, | ||
| {"shinespark": {"frames": 1, "excessFrames": 1}} | ||
| {"shinespark": {"frames": 1, "excessFrames": 1}}, | ||
| {"or": [ |
There was a problem hiding this comment.
Reason for this addition? The flash suit is gone before you crouchjump.
There was a problem hiding this comment.
it's just a thing you have to do. Should we assume that it's not needed?
There was a problem hiding this comment.
It comes down to CrouchJump/DownGrab in a flash suit strat so it can be assumed you know how.
There was a problem hiding this comment.
i think we have typically kept it, but it seems unnecessary to me. i can rip it out here.
No description provided.