Skip to content

fix: dereference *string in fmt.Errorf for HaChassisGroup #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dong Ma (larainema) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: dereference *string in fmt.Errorf for HaChassisGroup #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/ovnrouter/ovnrouter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,10 @@ func (m *Manager) Failover(ctx context.Context, router *apiv1alpha1.Router) erro
}
}

if gatewayPortInfo == nil {
return fmt.Errorf("no gateway chassis found for router %q", router.UID)
}

lrp := nbdb.LogicalRouterPort{UUID: string(*gatewayPortInfo.InternalUUID)}
if err := m.client.Get(ctx, &lrp); err != nil {
return fmt.Errorf("failed to get logical router port %q for router %q: %w", gatewayPortInfo.UUID, router.UID, err)
Expand All @@ -203,7 +207,7 @@ func (m *Manager) Failover(ctx context.Context, router *apiv1alpha1.Router) erro
if lrp.HaChassisGroup != nil {
haChassisGroup := nbdb.HAChassisGroup{UUID: *lrp.HaChassisGroup}
if err := m.client.Get(ctx, &haChassisGroup); err != nil {
return fmt.Errorf("failed to get HA chassis group %q for logical router port %q: %w", lrp.HaChassisGroup, lrp.UUID, err)
return fmt.Errorf("failed to get HA chassis group %q for logical router port %q: %w", *lrp.HaChassisGroup, lrp.UUID, err)
}

haChassis := []nbdb.HAChassis{}
Expand Down
Loading