Fix callback signature mismatch and add new payment methods (DANA & OTHERBANKVA)#94
Open
justpiple wants to merge 3 commits intovermaysha:masterfrom
Open
Fix callback signature mismatch and add new payment methods (DANA & OTHERBANKVA)#94justpiple wants to merge 3 commits intovermaysha:masterfrom
justpiple wants to merge 3 commits intovermaysha:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes an issue with callback signature verification and adds new payment methods to the payment module.
Bug Fix
JSON.stringify(body)instead ofbody.toString().toString()returning"[object Object]"when applied to an object.Payment Methods Update
DANAandOTHERBANKVApayment methods.isPaymentMethodhelper andPaymentMethodtype to include the new methods.